Special treat for Calguns Linux users

[pokute]

Run Linux? Then you will know what to do with this:

#!/bin/ksh
#
# Simple script to be run via cron:
#
#   5 * * * * ~/powder-valley.sh
#
 
email='me@mail.dom'
 
in_stock="\nhttp://www.powdervalleyinc.com/primers.shtml\n\n"
 
command='links -force-html -dump'
 
cci_query='http://www.powdervalleyinc.com/CCIprimers.shtml'
cci_primer_rx='CCI(300|350|500|550).+(Yes)'
 
federal_query='http://www.powdervalleyinc.com/FEDprimers.shtml'
federal_primer_rx='FED(100|200|150|155).+(Yes)'
 
remington_query='http://www.powdervalleyinc.com/REMprimers.shtml'
remington_primer_rx='REM(1.5|2.5|5.5).+(Yes)'

typeset -i in_stock_chars=${#in_stock}
 
IFS=$'\n'
 
data=$(eval $command $cci_query)
 
for line in $data
do
   if [[ "$line" =~ $cci_primer_rx ]]
   then
      in_stock="${in_stock}\n$line"
   fi
done
 
data=$(eval $command $federal_query)
 
for line in $data
do
   if [[ "$line" =~ $federal_primer_rx ]]
   then
      in_stock="${in_stock}\n$line"
   fi
done
data=$(eval $command $remington_query)
 
for line in $data
do
   if [[ "$line" =~ $remington_primer_rx ]]
   then
      in_stock="${in_stock}\n$line"
   fi
done

if [[ ${#in_stock} -gt $in_stock_chars ]]
then
   print $in_stock |mail -s 'Powder Valley Primers In Stock!' $email
fi

[spamsucker]

nice. Any reason you didn't use wget or curl instead of links (lynx, elinks)?

[pokute]

nice. Any reason you didn't use wget or curl instead of links (lynx, elinks)?

lynx or w3m would also work. The output from the "browsers" is both easier to parse and more robust than the "scrapers" because even if the site changes the way it generates the tables, or changes the table appearance, the parsing doesn't break because the table rendering code in links, lynx, and w3m reduces the table to a sane, basic form.

Anyway, I like links. I even use it to browse!

BTW, I formatted the code the way I did, without using an outer loop, to make it trivially easy for folks to extend the script by just cutting and pasting.

[RM14]

eval? Bad idea. Use backticks to execute commands.

data=`$command $cci_query`

[spamsucker]

Here... I improved it (at least from my point of view, it works on my mac now).

#!/bin/bash
mailaddr="you@mail.dom"


for BRAND in CCI CHE FED REM TUL WIN
do
########### BEGIN Pick Your OS ##########
# Comment out the appropriate line
# MAC OS
LYNXPATH="/Applications/Lynxlet.app/Contents/Resources/lynx/bin/lynx"
INSTOCK=`${LYNXPATH} -force-html -dump http://www.powdervalleyinc.com/${BRAND}primers.shtml | grep ${BRAND} | grep Yes`

# Linux and many Unix's
#LYNXPATH=`which lynx`
#INSTOCK=`${LYNXPATH} -force-html -dump http://www.powdervalleyinc.com/${BRAND}primers.shtml | grep ${BRAND} | grep Yes`
########### END Pick Your OS ##########
if [ "${INSTOCK}" != '' ]
then
echo "${INSTOCK}" | mail -s "Primers in stock at Powder Valley" $mailaddr
echo "${BRAND}\n ${INSTOCK}"
fi
done

What struck me about it was that you had so many variables defined needlessly. I figure a for loop could recurse through the brands with a single bit of instructions and it's easier for me to read this way. I've added Tula, Cheddite and Winchester brands to the list. I think it works better now.

[pokute]

eval? Bad idea. Use backticks to execute commands.

data=`$command $cci_query`

eval is only bad if commandline or cgi arguments are passed to it. Which they aren't here.
Shells have an eval command for a good reason, not just because they want to trip you up.

[pokute]

Here... I improved it (at least from my point of view, it works on my mac now).

I don't want email for every primer that's made, only for the ones I might need.

Also, note:

OS=`uname`

Linux () {
 echo Linux!
}

SunOS () {
 echo Solaris!
}

Darwin () {
 echo OSX!
}

${OS};

OSX ships ksh now, so you can stop calling grep (and sed, and awk).

[vtrigger77]

Whats a linux? Lol

[DMorris2321]

I would of floppy disked back up dos for improved Ram

[rjpsb1]

Also, use $(expression) instead of backticks. As suggested to me by the author of bash.

[pokute]

Also, use $(expression) instead of backticks. As suggested to me by the author of bash.

You see any backticks in the script? There aren't any.

Geez, I post something useful, and I get mostly flack for it... Fine, just keep sittin' there in your lawn chair at Walmart.

[locosway]

You see any backticks in the script? There aren't any.

Geez, I post something useful, and I get mostly flack for it... Fine, just keep sittin' there in your lawn chair at Walmart.

Why didn't you write a web interface and allow CGN members to signup for which alerts they want and host everything for free for us???

Stop being so selfish!

[rjpsb1]

You see any backticks in the script? There aren't any.

Geez, I post something useful, and I get mostly flack for it... Fine, just keep sittin' there in your lawn chair at Walmart.

Post #4 said use backticks. I didn't say you did. But thanks for the hostility.

[the86d]

Run Linux? Then you will know what to do with this:

#!/bin/ksh
#
# Simple script to be run via cron:
#
#   5 * * * * ~/powder-valley.sh
#
 
email='me@mail.dom'
 
in_stock="\nhttp://www.powdervalleyinc.com/primers.shtml\n\n"
 
command='links -force-html -dump'
 
cci_query='http://www.powdervalleyinc.com/CCIprimers.shtml'
cci_primer_rx='CCI(300|350|500|550).+(Yes)'
 
federal_query='http://www.powdervalleyinc.com/FEDprimers.shtml'
federal_primer_rx='FED(100|200|150|155).+(Yes)'
 
remington_query='http://www.powdervalleyinc.com/REMprimers.shtml'
remington_primer_rx='REM(1.5|2.5|5.5).+(Yes)'

typeset -i in_stock_chars=${#in_stock}
 
IFS=$'\n'
 
data=$(eval $command $cci_query)
 
for line in $data
do
   if [[ "$line" =~ $cci_primer_rx ]]
   then
      in_stock="${in_stock}\n$line"
   fi
done
 
data=$(eval $command $federal_query)
 
for line in $data
do
   if [[ "$line" =~ $federal_primer_rx ]]
   then
      in_stock="${in_stock}\n$line"
   fi
done
data=$(eval $command $remington_query)
 
for line in $data
do
   if [[ "$line" =~ $remington_primer_rx ]]
   then
      in_stock="${in_stock}\n$line"
   fi
done

if [[ ${#in_stock} -gt $in_stock_chars ]]
then
   print $in_stock |mail -s 'Powder Valley Primers In Stock!' $email
fi

I'll give this a go when I get on work rig...

I would of floppy disked back up dos for improved Ram

Make sure to signal when required while driving.

[SoCal326]

Thanks for the script.

I wouldn't take it personally that people are commenting on your code. It's pretty common at my company to have someone look over code and offer suggestions to improve it. You will see this same behavior on any community maintained project. It's just how code gets better.

I'm not saying any changes were needed, just don't take it personally.